Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve display of nested documents when shown as a column with fields API #92223

Closed
Tracked by #170754
wylieconlon opened this issue Feb 22, 2021 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:FieldFormatters Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@wylieconlon
Copy link
Contributor

When using the fields API, nested documents get shown as single-line JSON without formatting. It would be preferable to display each nested JSON object using full formatting if possible.

Requirements to test:

  1. Stop fetching data using _source, use the fields API
  2. Have a nested mapping in the index containing nested objects
  3. Legacy table or data grid are both affected

I will update this issue with an example and mocks.

@wylieconlon wylieconlon added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor Author

To keep the single-line display, we could use a simple separator like a bullet point:

Screen Shot 2021-02-22 at 3 34 55 PM

We could also expand this to a multi-line display if it's helpful by using horizontal separators:

Screen Shot 2021-02-22 at 3 25 58 PM

I think the bullet point approach is probably not clear enough, it probably needs to be an icon of some kind.

@kertal
Copy link
Member

kertal commented Feb 23, 2021

a multi line approach would not work well in data grid cells due to height limit, but when expanding a cell, this could be helpful
About the separator of array entries, what do you think we could use for a clear separation dear @elastic/kibana-design ? ✂️ ?

@ryankeairns
Copy link
Contributor

a multi line approach would not work well in data grid cells due to height limit, but when expanding a cell, this could be helpful
About the separator of array entries, what do you think we could use for a clear separation dear @elastic/kibana-design ? ✂️ ?

What do you think about using some sort of standard array notation with brackets? ( e.g. [{entry},{entry}] or just [entry],[entry] ). I'm thinking that wrapping each entry would make it immediately clear, even in a short cell, that multiple entries are being displayed as there would be an opening bracket at the front. Conversely, it will be difficult to visually parse a single character between entries, imo.

If the only option is a character between, then a comma or dot may work.

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@ninoslavmiskovic ninoslavmiskovic added Feature:FieldFormatters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 8, 2022
@MJonker
Copy link

MJonker commented Aug 11, 2023

Is there a way that we ourselves (as customers) determine the UI of a nested field in a column, like field preferred formatting ?

@davismcphee davismcphee added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 8, 2023
@kertal
Copy link
Member

kertal commented Nov 27, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
@kertal kertal added the Icebox label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:FieldFormatters Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

8 participants