Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic deep links for Solution apps #92153

Closed
joshdover opened this issue Feb 22, 2021 · 2 comments
Closed

Add basic deep links for Solution apps #92153

joshdover opened this issue Feb 22, 2021 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

#83380 added support for Kibana apps to provide deep links to be populated in the navigation search bar results.

Thus far, not many teams have been able to prioritize doing the work to add these links, these apps still remain:

The reason we opted not to do this for teams directly is because in order to keep the code DRY we would need to move some code around in order to share the strings for route paths with the React code and the deep link code.

We could compromise on this and duplicate these strings + add a comment that indicates where to update this code when either location changes. This would be a bit more 'hacky' but would help us get more consistency in the search experience sooner. This should be prioritized for later in 7.13 so that if other teams do have bandwidth to do it the right way, that happens first.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Feb 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover
Copy link
Contributor Author

Since the low-hanging fruit here has been done, I'm going to close this out and leave the other individual issues open to track the harder-to-change apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants