Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Re-use components between Service overview and Transactions Overview instead of duplication #91848

Closed
5 tasks done
sorenlouv opened this issue Feb 18, 2021 · 4 comments · Fixed by #107299
Closed
5 tasks done
Assignees
Labels
apm:service-overview apm:ux-refresh enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.15.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Feb 18, 2021

Many of the components on the Service overview and transactions overview are essentially duplications of the same.

  • Latency chart
  • Transactions group table
  • Throughput chart
    • Might not be possible to combine. One breaks requests down by transaction.result
    • api/apm/services/opbeans-dotnet/throughput
    • api/apm/services/opbeans-dotnet/transactions/charts/throughput
  • error rate chart
    • Doesn't seem to be duplicated but please double check
  • time spent by span type
    • Doesn't seem to be duplicated but please double check

Related: #82261

@sorenlouv sorenlouv added [zube]: Inbox apm:service-overview enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.13.0 labels Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@alex-fedotyev
Copy link

Created a separate issue for transaction view.

We still need to decide what we need to show on the transactions list, here are open questions:

  1. Current list shows 95th percentile and Avg on the same grid, and if we re-use the transactions table from the overview, would we lose that?
  2. The top charts on the current transactions page are mostly duplicates from what we have on the service overview page. Do we need to keep them there and if yes, what do users use them for when choosing which transaction to drill down to?

@alex-fedotyev
Copy link

I suggest to drop p95 from the columns in this version.
Not ideal likely, but it feels less important than other improvements and fixes.

@formgeist
Copy link
Contributor

The top charts on the current transactions page are mostly duplicates from what we have on the service overview page. Do we need to keep them there and if yes, what do users use them for when choosing which transaction to drill down to?

We already have a redesign in place for updating those top charts to smaller yet valuable indicators of performance which the user can use to narrow down to a specific time period, if they haven't already done this from the overview. Otherwise, I think we're forcing them to move back and forth to get a metrics overview of the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-overview apm:ux-refresh enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.15.0
Projects
None yet
5 participants