Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix search source behavior #91459

Closed
timroes opened this issue Feb 16, 2021 · 1 comment · Fixed by #91517
Closed

[Discover] Fix search source behavior #91459

timroes opened this issue Feb 16, 2021 · 1 comment · Fixed by #91517
Assignees
Labels
Feature:Discover Discover Application Project:Fields Access field values from fields response, not source Project:RuntimeFields Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 16, 2021

  • Change search source structure: persistent search source as parent + volatile search source as child used for actual querying
  • Peristent search source is linked to the saved object so it's saved
  • Volatile search source stores things like time range, fields, sorting, highlightAll, version, size
  • Persistent search source stores things like index pattern, query, filters
  • Reporting uses volatile search source (serializeWithParents)
    • This means reporting needs to handle migration once we change the search source serialization in a breaking manner
    • Either handled internally or moving to saved objects
  • In the search embeddable, load the persistent search source from the saved object, then re-create the volatile one in memory (should be a separate helper)
  • Make sure getSharingData includes all relevant parts to pass to the reporting plugin
@timroes timroes added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure Project:RuntimeFields Project:Fields Access field values from fields response, not source labels Feb 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Project:Fields Access field values from fields response, not source Project:RuntimeFields Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants