Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Cancel search session dialog is confusing for a completed, errored or expired session #89276

Closed
Dosant opened this issue Jan 26, 2021 · 9 comments · Fixed by #90015
Assignees
Labels
Feature:Search Querying infrastructure in Kibana v7.12.0 v8.0.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 26, 2021

Part of #61738
Follow up on #61741

Noticed this small thing that confused me. I guess “cancel” for the completed session doesn’t make sense and should be “remove” or “delete” instead?

I think the same applies for the session in the "error" or "expired" state

Screenshot 2021-01-25 at 16 56 19
Screenshot 2021-01-25 at 16 56 34

@mdefazio, @lizozom, @tsullivan, wdyt?

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana Team:AppServices labels Jan 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mdefazio
Copy link
Contributor

Noticed this small thing that confused me. I guess “cancel” for the completed session doesn’t make sense and should be “remove” or “delete” instead?

@Dosant , yes, I agree. 'Delete' kind of implies that I can no longer do anything with it. But I'm able to reload it if I choose, correct? Maybe that's thinking too far into it, so I'm curious to see what others think. Maybe 'Archive'?

@Dosant
Copy link
Contributor Author

Dosant commented Jan 26, 2021

@mdefazio, when you click "cancel" on that screen above search session disappears from the list, so you can't anymore use "reload". It seems like under the hood it is actually deleted (I am not sure).

Not sure if this is intentional or a bug.

@lizozom
Copy link
Contributor

lizozom commented Jan 26, 2021

@Dosant this needs to be addressed by one of @lukasolson PRs.
Canceled search sessions will still appear on the list and you will be able to reload them.

@Dosant
Copy link
Contributor Author

Dosant commented Jan 26, 2021

@lizozom, thanks, that explains then.
Is there a way to remove/delete a session from that screen? In case I am no longer interested and don't want that list to get longer and longer? Are expired sessions disappear from that list with time?

@lizozom
Copy link
Contributor

lizozom commented Jan 26, 2021

@Dosant not at the first MVP phase.
Things will just stay and get stale, as everything is sorted by creation time.
But this is definitely the plan for future versions.

@lizozom
Copy link
Contributor

lizozom commented Jan 26, 2021

@gchaps maybe you can review the text and buttons on this dialog?

@lizozom
Copy link
Contributor

lizozom commented Feb 2, 2021

After deliberating with @Dosant, we decided the action to be deleting the search sessions rather than canceling them.
This will lead to simpler implementation and it's not a critical behavior.

#90015

@mdefazio
Copy link
Contributor

mdefazio commented Feb 2, 2021

Discussed with @gchaps and here is copy for the delete modal:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants