Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Users can insert vertical line annotations on timeseries charts #87564

Closed
wylieconlon opened this issue Jan 6, 2021 · 8 comments
Closed
Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Jan 6, 2021

This issue depends on a decision on where to store annotation data as well as the ability for visualizations to have multiple layer types and to query data asynchronously for visualizations.

There are three important user flows that we should support:

  1. Displaying previous created annotations onto a Lens chart, with options to filter the visible tags (such as "production")
  2. Inserting a vertical line annotation with name and tags
  3. Deleting a previous annotation

Each time the visualization time range is updated, the annotations need to be queried again, so that we only show annotations within the time range:

Screen Shot 2021-01-04 at 2 14 34 PM

User flow to insert annotation

I think users need to click on the chart to insert an annotation, so I think the flow here starts on the annotation list:

Screen Shot 2021-01-05 at 2 58 09 PM

Users will click "insert annotation", which causes the chart to enter edit mode. The next click on the chart will set the marker and open the popover to type the label and tags.

@wylieconlon wylieconlon added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@shahzad31
Copy link
Contributor

Can we please prioritise this, this is one of the key feature for our page load distribution chart, which we are planing to implement via lens embeddable in https://github.com/elastic/uptime-dev/issues/46

@wylieconlon
Copy link
Contributor Author

@shahzad31 I don't think this issue is the right one for your use case, but it depends on where the data will be stored. This issue is specifically for annotations that are owned by the Lens app, not annotations from external sources. We are also tracking an issue to query ES for annotation data as a read-only source.

It's also possible that your use case is not on our roadmap right now, and we may need to open a new issue or reorganize the existing issues.

@wylieconlon
Copy link
Contributor Author

@shahzad31 Sounds like you've talked with @flash1293. Based on this clarification, the right issue for you is this one: #87551

@timductive timductive added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Feb 14, 2022
@unixsurfer
Copy link

I do miss the annotation feature on Lens. My use-case is to have a vertical line to show when a change is applied on systems, so I can correlate systems changes in errors and/or drop of requests. The information about when a change is applied is stored on another doc and it is quite easy to extract it with a filter on an index.

Does anyone know if Lens will get support for this?

@flash1293
Copy link
Contributor

@unixsurfer we are currently working on this very feature - see #119240 for our preliminary roadmap

@unixsurfer
Copy link

@flash1293 thanks a lot for the quick reply.

@ghudgins
Copy link
Contributor

ghudgins commented May 2, 2022

8.2 delivers the core tech preview of this issue. #62277 will be used to track the query-based aspects of these requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants