Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Group multifields in document table view #85941

Closed
majagrubic opened this issue Dec 15, 2020 · 3 comments
Closed

[Discover] Group multifields in document table view #85941

majagrubic opened this issue Dec 15, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application needs design Project:Fields Access field values from fields response, not source

Comments

@majagrubic
Copy link
Contributor

majagrubic commented Dec 15, 2020

Similar to grouping multifields in sidebar, we need to group multifields in the table view. We've considered the following options:

  1. Show a tooltip, similar to how it's done in the sidebar
    Pros: looks nice, not too complicated to implement
    Con: the field becomes "hidden", which, in a document view, I'm not sure we want. As a user, I'd expect to be able to see all the fields at a glance

  2. Group multifields in the table itself, so that somehow there's a visible distinction between them
    Pros: fields visible at a glance, not too complicated to implement
    Con: inconsistent?
    Here's what I was thinking of:

Screenshot 2020-12-15 at 10 10 49

  1. Hybrid between option 2 and 3: just show the tooltip behind the field name showing other (multifield) names, and only list the values where value is different than the parent value.
    Pros: looks nice, fields visible at a glance
    Cons: inconsistent, complex to implement

Note that the ES is planning for keyword multifield to go away by 8.0.0. If it goes according to plan, we ideally don't want to spend too much time/effort implementing this now. The ideal solution is something that looks nice, doesn't require too much effort to implement, and can easily be removed once the time comes 😬

Any thoughts on this? @andreadelrio

@majagrubic majagrubic added Feature:Discover Discover Application Project:Fields Access field values from fields response, not source needs design enhancement New value added to drive a business result labels Dec 15, 2020
@andreadelrio
Copy link
Contributor

andreadelrio commented Jan 12, 2021

image

@majagrubic I think option 2 works. For consistency, I'd add a title like in the screenshot above.
Questions:

  • Do we want to add the type of field token to the left of the field name? (i.e. t for string, etc)
  • Will the multifields also have the four actions available? (i.e. filter for value, filter out value, filter for field present, toggle column)

@majagrubic
Copy link
Contributor Author

I think having field type next to the field name is optional; I don't think a lot of information is lost without it. We should add actions, yes, since the sidebar already has actions on those fields.

@andreadelrio
Copy link
Contributor

I think having field type next to the field name is optional; I don't think a lot of information is lost without it. We should add actions, yes, since the sidebar already has actions on those fields.

@majagrubic Here's a mock showing actions for mutifields.

Screen Recording 2021-01-12 at 9 48 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application needs design Project:Fields Access field values from fields response, not source
Projects
None yet
Development

No branches or pull requests

2 participants