Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Should make sure license check completes at startup #85863

Closed
thomasneirynck opened this issue Dec 14, 2020 · 1 comment · Fixed by #87873
Closed

[Maps] Should make sure license check completes at startup #85863

thomasneirynck opened this issue Dec 14, 2020 · 1 comment · Fixed by #87873
Assignees
Labels
bug Fixes for quality problems that affect the customer experience chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Dec 14, 2020

Kibana version:

7.x, master

Describe the bug:

Kibana Maps performs a license check by subscribing to the license$ observable on plugin-start.

licensingPluginStart.license$.subscribe((license: ILicense) => {

There are no guarantees in the order these are fired. Subtle edge-case bugs may arise on Kibana startup, where up2date license info is not available.

A similar fix was made on the server-side #84806. This should be fixed on the client-side code of the Maps-plugin as well.

cc @nickpeihl @jsanz this is likely affecting some of the oddities we're seeing in on-prem EMS deployments.

@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck changed the title [Maps] Should do license check at init [Maps] Should make sure license check completes at startup Dec 14, 2020
@thomasneirynck thomasneirynck self-assigned this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants