Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support installable but not add-able integrations #85833

Open
nchaulet opened this issue Dec 14, 2020 · 8 comments
Open

[Fleet] Support installable but not add-able integrations #85833

nchaulet opened this issue Dec 14, 2020 · 8 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@nchaulet
Copy link
Member

Description

The Elastic Agent integration (elastic/integrations#462) introduce a new concept of integration that you can install but not add to an agent policy.

Installing the Elastic agent integration will create dashboards for the Elastic Agent, but there is not point to add the integration to an agent policy as monitoring an agent is done through different property on the agent policy.

Should we add a new flag on the package that allow to install and integration but not to add it to an agent policy

Should we treat monitoring as other integration? and add the Elastic Agent integration to the agent policy

@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ycombinator
Copy link
Contributor

@mtojek An issue to keep an eye on as it might affect the package spec, validation, potentially testing with elastic-package, etc.

@ph ph added Team:Fleet Team label for Observability Data Collection Fleet team and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 14, 2020
@ph
Copy link
Contributor

ph commented Dec 14, 2020

Adding a note, the Elastic Agent package is a use case. I think we should extend that to more than just that specific integration.
Imagine a world where multiple kind of integration exists, some can be installed only in Kibana (like ML job), some can installed on the Elastic Agent, some are only documentation. This is a bit linked to the integration UI effort.

cc @jen-huang @mostlyjason @ruflin

@mostlyjason
Copy link
Contributor

mostlyjason commented Dec 14, 2020

Can someone share context for what data this dashboard is showing? It looks like CPU and memory which seems similar to stack monitoring data. Is this the data you get when you create an agent policy and select "collect system metrics"?

If so, why not just make it an input like all the others? Then we don't need special-case configuration or logic, it'd just be a regular integration with a regular input. We could make it a default integration similar to the system integration, so its available for all agents unless they remove it from their agent policy.

@ruflin
Copy link
Member

ruflin commented Dec 14, 2020

From my perspective, it is just a package without any input templates. A package without an input template should be shown in the list, can be installed but should not show up in the "add integrations" view.

@mostlyjason Interesting idea, but I'm not sure it is something we should let users configured like all the other parts as it will become an integral part for Fleet and these metrics / logs must be available. Otherwise a user might remove them and is surprise that some things might then not work anymore.

@mostlyjason
Copy link
Contributor

@ruflin if they uncheck "collect system metrics" what will stop working? i assume its just the logs/metrics on the agent details page, but the agent keeps running and they can still manage it in fleet?

@nchaulet
Copy link
Member Author

if they uncheck "collect system metrics" what will stop working? i assume its just the logs/metrics on the agent details page, but the agent keeps running and they can still manage it in fleet?

Yes the agent will still run we will just not have logs/metrics

@ph ph added the v7.13.0 label Dec 16, 2020
@ruflin
Copy link
Member

ruflin commented Dec 17, 2020

@mostlyjason I expect that in the future coordinator in fleet-server will make some decision on these metrics / logs. But that is also likely going to be in addition shipped through the status so things should keep working.

@ph ph removed the v7.13.0 label Feb 15, 2021
@jen-huang jen-huang changed the title [Fleet] Support Elastic Agent package [Fleet] Support installable but not add-able integrations Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants