Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add attribute allowNoIndex to Fleet index patterns #85627

Closed
neptunian opened this issue Dec 10, 2020 · 3 comments
Closed

[Fleet] Add attribute allowNoIndex to Fleet index patterns #85627

neptunian opened this issue Dec 10, 2020 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0

Comments

@neptunian
Copy link
Contributor

neptunian commented Dec 10, 2020

This #82223 changes how index patterns are loaded into the UI by looking in ES to create the index patterns. In the case of Fleet, indices may not exist yet. Because of our index placeholder which has no fields, it would overwrite the index patterns in our saved objects (logs-*, metrics-*) to nothing. You can see this issue by going to Fleet app (new index patterns will be created with the installed packages fields, such as logs-*). Go to Stack Management -> Index Patterns -> logs-*. There are no fields in the index patterns.

To solve this #85370 will continue to use the saved object index patterns and if we add a new attribute ignoreIndexNotFound, it will not 404 when it finds no indices. No error message will be displayed.

For Fleet this means we need to make a few changes:

  • remove the index placeholders we create and check for during setup
  • remove readFromDocValues in each field
  • add the allowNoIndex attribute to our index patterns during creation
  • create a migration to add the above attribute to the existing index patterns

Related: #65284
Depends on: #85370

@neptunian neptunian added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 10, 2020
@neptunian neptunian self-assigned this Dec 10, 2020
@neptunian neptunian added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@neptunian
Copy link
Contributor Author

neptunian commented Dec 15, 2020

Changes for this will be in this PR #85370.

The readFromDocValues will be done in a separate PR after FF as it is not doing anything right now and i'd rather lower the risk of changing that.

@mattkime Will be doing the index-pattern saved object migration as the migration should be written in the data plugin.

@neptunian neptunian changed the title [Fleet] Add attribute ignoreIndexNotFound to Fleet index patterns [Fleet] Add attribute allowNoIndex to Fleet index patterns Dec 15, 2020
@neptunian
Copy link
Contributor Author

Most changes made in #85370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

2 participants