[Visualize] Badges on OSS inactive cards appear with the external link icon

[stratoula]

Kibana version:
master

Describe the bug:
It's is not a bug but is a look and feel issue. When the new visualization wizard has merged the badges of the inactive cards on OSS were redirecting to external links but the icon was not depicted.

But I think that there was a change on EUI that every link that has target=_blank should default to true. This change has caused the badges to appear with an icon.

Before:

Now:

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[stratoula]

@elastic/kibana-design My dear design team I need your opinion on that. I can see two paths:

• add the external=false but I don't think that this is correct here as they redirect to an external link actually
• hide this icon with css
  .visNewVisDialog__groupsCardLink .euiLink__externalIcon { display: none; }

Or maybe another idea 🤔 Wdyt?

[elizabetdev]

Hi @stratoula,
IMO we should just add external=false to the EuiLink. This prop only removes the icon but the link continues to have the target="_blank".

There's actually an issue with the way the EuiBadge is handling the links and we need to solve it in EUI side: elastic/eui#4190.

So I'll try to prioritize it. 🙌

[stratoula]

Thank you dear! Will create a PR right now!