Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Show alert annotations on charts #85479

Closed
sorenlouv opened this issue Dec 9, 2020 · 4 comments
Closed

[APM] Show alert annotations on charts #85479

sorenlouv opened this issue Dec 9, 2020 · 4 comments
Labels
apm:alerting apm:service-overview blocked Team:APM All issues that need APM UI Team support Theme: rac label obsolete v7.13.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Dec 9, 2020

Blocked by: #90627

Show alerts as annotations on latency chart. The alert instance should be displayed at the time it occurred. On hover it should be possible to see the threshold and the value that exceeded the threshold.
image.png

Only alerts matching the currently selected service.name and service.environment (via alert params) should be displayed.

@pmuellr
Copy link
Member

pmuellr commented Jan 20, 2021

On hover it should be possible to see the threshold and the value that exceeded the threshold.

We don't currently track the value or threshold at the time the alert executors run. Presumably the value would be available in the sourced data (blue line in the graph ^^^). But we also don't track the threshold - I suspect that this will become possible once we have a "alerts as data" story, where an alert will be able to store alert-specific data ... somewhere ... when the alert executors run. Today, we only store alert-generic data (so, not much).

Only alert instances matching the currently selected service.name and service.environment should be displayed.

I assume service.name etc are alert parameters? If so, we don't yet support any way of searching filtering based on the alert params - they aren't indexed - but are looking into right now via issue #50213

Show alert instances as annotations on latency chart.

Beyond what I mentioned above, the event log can provide timestamps for when alerts are active ("active-instance"), when they have just become active after not being active before ("new-instance"), when they are no longer active after they being active before ("recovered-instance"), errors (fields from the "execute" doc), and when actions have been invoked because the alert was active ("execute-action"). I think the timestamps will be the only interesting bit of info here (besides the alert id, etc).

Should be enough to show the vertical lines in the graph ^^^ ; If the pink-shaded areas are "alert was active", you can bound those by "new-instance" and "recovered-intstance" events, but keep in mind the query may not contain ALL the data, so you could have a string of "active-instance" events, with no "new-" or "recovered-" event, which would indicate the alert has been firing since before the data returned from the query, and/or beyond the data returned from the query (or possibly still active).

@sorenlouv
Copy link
Member Author

sorenlouv commented Jan 20, 2021

Thanks for the feedback @pmuellr!

We don't currently track the value or threshold at the time the alert executors run

That's fine for for now.

I assume service.name etc are alert parameters? If so, we don't yet support any way of searching filtering based on the alert params - they aren't indexed - but are looking into right now via issue #50213

Yes, we are hoping to retrieve alerts by alert params.

the event log can provide timestamps for when alerts are [...]

I think timestamps for "execute-action" is the only useful one for us.
Out of curiosity: You mention timestamps for "active-instance", "new-instance", "recovered-instance". I've thought of these as implementation details - in what way would these be useful to consumers and/or end users? Sorry, it looks like you explain this further down: we can use those timestamps to determine when an alert started firing ("new-instance") and stopped again ("recovered-instance")

@sorenlouv sorenlouv changed the title [APM] Service overview: Show alert annotations [APM] Show alert annotations (proactive workflow) Feb 21, 2021
@sorenlouv sorenlouv changed the title [APM] Show alert annotations (proactive workflow) [APM] Show alert annotations (reactive workflow) Feb 21, 2021
@sorenlouv sorenlouv added the Theme: rac label obsolete label Mar 4, 2021
@sorenlouv sorenlouv changed the title [APM] Show alert annotations (reactive workflow) [APM] Show alert annotations on charts (reactive workflow) Mar 15, 2021
@sorenlouv sorenlouv changed the title [APM] Show alert annotations on charts (reactive workflow) [APM] Show alert annotations on charts Mar 15, 2021
@sorenlouv
Copy link
Member Author

Closing. @katrin-freihofner will create a new issue to replace this.

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 8, 2021
@mikecote mikecote added Team:APM All issues that need APM UI Team support and removed needs-team Issues missing a team label labels Apr 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting apm:service-overview blocked Team:APM All issues that need APM UI Team support Theme: rac label obsolete v7.13.0
Projects
None yet
Development

No branches or pull requests

5 participants