Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetryCollectionManager to use X-Pack strategy as a replacement of the OSS strategy #83622

Closed
afharo opened this issue Nov 18, 2020 · 2 comments · Fixed by #84477
Closed
Assignees
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Nov 18, 2020

As part of the decoupling process of Telemetry & Monitoring, and after #82638 is completed, we need to change the way the telemetryCollectionManager currently works: At the moment, it loops through a priority-based list of strategies until it gets any results.

This comes with the risk of the X-Pack strategy failing for any glitch and the collection manager would fallback to the OSS strategy. This is forcing the OSS to be aware of X-Pack features in order to provide the expected results (i.e.: OSS attempts to collect the license information, even when OSS does not have any license information at all #82963).

This issue is to change this behaviour and let the telemetryCollectionManager to use the X-Pack strategy to overwrite the OSS one instead of using both as fallbacks.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo self-assigned this Nov 26, 2020
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants