Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] (Accessibility) Improve screen reader announcement of the layer settings button #83599

Closed
myasonik opened this issue Nov 17, 2020 · 2 comments · Fixed by #84493
Closed
Assignees
Labels
accessibility best practice enhancement New value added to drive a business result Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@myasonik
Copy link
Contributor

The problem

The layer settings button (which has the chart type picker popover) also visually indicates the chart type but requires extra navigating for screen reader users to get the same context.

The fix

Two possible ways to fix this:

  • If you have it available somewhere on the page, could add an aria-describedby={idOfTheString} pointing to the chart type.
  • If not, could extend the aria-label to read something like Edit layer settings; {chartType} (instead of the current Edit layer settings)
@myasonik myasonik added Project:Accessibility enhancement New value added to drive a business result loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens accessibility best practice labels Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@flash1293 flash1293 changed the title (Accessibility) Improve screen reader announcement of the layer settings button [Lens] (Accessibility) Improve screen reader announcement of the layer settings button Nov 18, 2020
@mbondyra mbondyra self-assigned this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility best practice enhancement New value added to drive a business result Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants