Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Index Threshold doesn't support multiple Action Groups #83270

Closed
gmmorris opened this issue Nov 12, 2020 · 5 comments
Closed

[Alerting] Index Threshold doesn't support multiple Action Groups #83270

gmmorris opened this issue Nov 12, 2020 · 5 comments
Labels
enhancement New value added to drive a business result estimate:small Small Estimated Level of Effort Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

gmmorris commented Nov 12, 2020

Follow up from #82412.

Once the generic Conditions component is delivered by #82412, we want to use it to add Alert/Warning/Error thresholds to the Index Threshold Alert Type

Screenshot 2020-11-03 at 11 08 09

@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote added the enhancement New value added to drive a business result label Nov 12, 2020
@pmuellr
Copy link
Member

pmuellr commented Nov 12, 2020

We need to decide how we want this to work. Let's say we have Alert / Warning / Critical as the action groups. Is everything the same with all these groups but the threshold values? We'll need to logic in the UI and server to ensure these logically make sense. For a comparator of >, presumably the threshold values would compare as Alert < Warning < Critical. Kinda thing. How would == work? :-)

Maybe we already decided on this, not sure. And I guess it depends on how #83278 goes. Does that issue also implicate how we'll store these things within the alert as well, or will we make every alert's UI adapt to how the server represents this?

I can't remember if we discussed whether we should have some "default" action groups like Alert / Warning / Critical that alerts can opt-in to, but could extend if it wanted to, as well as perhaps opt-out of just some of them (just support Alert / Warning). This would probably be a great thing to have, if it actually makes sense.

Last thought for the moment; our current action group for index threshold is "met threshold". Specifically designed to be generic / agnostic. I think it probably makes sense to do away with that one, so we'd only have Alert / Warning / Critical, but this means during a migration, any active index threshold alerts will see an action group change. I think we'll be ok if the old action group isn't available any more after the migration, certainly would be a good thing to test, if we remember.

@gmmorris
Copy link
Contributor Author

Maybe we already decided on this, not sure. And I guess it depends on how #83278 goes. Does that issue also implicate how we'll store these things within the alert as well, or will we make every alert's UI adapt to how the server represents this?

Nope, totally up to the Alert Type - You can look at the example in Always Fires alert type in that PR.
The internal component used for each Action Group is totally up to the Alert Type and that type can decide how this data i stored, displayed etc.

All the #83278 PR does is provide a couple of reusable components that automatically render for each ActionGroup that has had conditions configured (supplied by the AlertType implementor) and pickers for selecting additional ActionGroups to configure.

It's designed to be as open as possible because being too restrictive makes it more likely implementors will avoid using it.
I recommend catching up on the recording from our sync on this from 2020-11-12.

@Shangguan
Copy link

It would be really great if Kibana users could define their own action groups in the UI pop-up (or via REST api once that is available), exactly as shown in the screenshot above for Index Threshold alert type, and for the Search DSL Alert type (that is going to be available soon).

Speaking on behalf of a customer - they would love the ability to define custom action groups and associate different actions per group. A good example is CPU Usage:

  • Minor action group: 50% - 70% of CPU Utilization, action of logging + email
  • Major action group: 70% - 80%, action of ServiceNow + Slack
  • Critical action group: 80% beyond, action of ServiceNow + PagerDuty + JIRA + Email + Slack

Numbers are contrived but you should get the idea...

@gmmorris gmmorris added the Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types label Jul 1, 2021
@gmmorris gmmorris added the loe:medium Medium Level of Effort label Jul 14, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@ymao1
Copy link
Contributor

ymao1 commented Nov 19, 2021

Closing due to lack of interest.

@ymao1 ymao1 closed this as completed Nov 19, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result estimate:small Small Estimated Level of Effort Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

7 participants