Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service overview: Only show data from default (or top) transaction type #82831

Closed
sorenlouv opened this issue Nov 6, 2020 · 4 comments · Fixed by #85665
Closed

[APM] Service overview: Only show data from default (or top) transaction type #82831

sorenlouv opened this issue Nov 6, 2020 · 4 comments · Fixed by #85665
Assignees
Labels
apm:service-overview Team:APM All issues that need APM UI Team support v7.11.0

Comments

@sorenlouv
Copy link
Member

  • The new service overview page won't have a transaction type selector.
  • To avoid mixing data between transaction types we need to select a single type automatically
  • If no transaction type is specified in the url we should show data from the default transaction type. The default transaction type for backend agents is request and page-load for RUM.
  • Some services might only have custom transaction types (no default transaction types) and in these cases we should show pick the transaction type with the most transactions (top bucket sorted by number of transactions)

Thoughts on implementation
I see two approaches:

  1. fetching transaction type data and perform redirect inside the service overview page
  2. fetching transaction type data on service inventory page and linking to service overview page with the type in the url

Related: elastic/apm#362 (comment)

@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

Just to clarify, this shouldn't change the current behavior on the Transaction views, where there's a transaction type filter option to switch between types.

@smith
Copy link
Contributor

smith commented Nov 18, 2020

This is not the case for the error rate chart and errors table at this time so those need to be updated.

@smith smith removed their assignment Nov 20, 2020
@smith smith self-assigned this Dec 10, 2020
@smith
Copy link
Contributor

smith commented Dec 10, 2020

Current status:

  • Latency chart (in open PR)
  • Traffic chart
  • Transactions table: Does not pass in transaction type or filter by it on the server
  • Error rate chart: Taking transactionType from url params not service context; does do filtering on the server
  • Errors table: Does not use transaction type in client or server requests
  • Average duration by span type chart
  • Dependencies table: We can't filter by transaction type here because span metrics do not have a transaction type
  • Instances latency distribution: Not done yet
  • Instances table: Not done yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-overview Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants