Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hapi to v20 #82805

Closed
mshustov opened this issue Nov 6, 2020 · 4 comments · Fixed by #85406
Closed

Upgrade Hapi to v20 #82805

mshustov opened this issue Nov 6, 2020 · 4 comments · Fixed by #85406
Labels
chore Feature:Dependencies release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Nov 6, 2020

We need to update hapi to the latest version with all the security fixes till the major release v8.0.
We might need to audit test coverage of the http server to make sure we cover all the user-facing behavior.

Release notes:

Blockers: Requires Nodejs v12 #61587
Dependencies: @elastic/kibana-security how soon you want to get it merged? It's not on our roadmap at the moment. Can you squeeze the issue into your backlog if the problem is time-sensitive?

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes Feature:Dependencies labels Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@legrego
Copy link
Member

legrego commented Nov 6, 2020

Blockers: Requires Nodejs v12 #61587

@watson is actively working on the Nodejs v12 upgrade, but needs assistance from other teams to debug test failures. We'll be in a good place to merge once those failures are resolved.

Dependencies: @elastic/kibana-security how soon you want to get it merged? It's not on our roadmap at the moment. Can you squeeze the issue into your backlog if the problem is time-sensitive?

Our only requirement is to upgrade before we reach 8.0, but yes this is something we can put in our backlog if we want to get this done before the core team has bandwidth. We'll likely leave the test coverage/audit to your team though.

@mshustov
Copy link
Contributor Author

mshustov commented Nov 10, 2020

Our only requirement is to upgrade before we reach 8.0, but yes this is something we can put in our backlog if we want to get this done before the core team has bandwidth.

@legrego That would be awesome!

We'll likely leave the test coverage/audit to your team though.

It's fine.

@watson watson mentioned this issue Dec 9, 2020
2 tasks
@watson
Copy link
Contributor

watson commented Dec 10, 2020

FYI: I've started working on this over at #85406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Dependencies release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants