Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Removal of Timelion app #82702

Closed
stratoula opened this issue Nov 5, 2020 · 7 comments
Closed

[Breaking change] Removal of Timelion app #82702

stratoula opened this issue Nov 5, 2020 · 7 comments
Labels
Breaking Change Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@stratoula
Copy link
Contributor

Change description

Which release will ship the breaking change?

8.0

Describe the change. How will it manifest to users?
We are planning to remove the timelion app on v8.0 (not the visualization). On 7.9 we introduced the following notifications to the users to inform them about this change in order to be able to move their existing sheets on a dashboard.

  • A warning on the timelion app (client-side) about the removal and a link to the documentation

Screenshot 2020-11-05 at 12 33 07 PM

  • A warning on the server with the same message. The warning is being displayed only if the user has existing worksheets.

How many users will be affected?
The timelion sheets usage from our telemetry data for the last year is depicted here:
Screenshot 2020-11-05 at 12 42 07 PM

What can users do to address the change manually?

The documentation for the users can be found here

How could we make migration easier with the Upgrade Assistant?

We would love to notify the users also during the migration to v8.0. It is very possible that even with our warnings, both on server and client-side, the users will never see them. We want to identify if the users have created timelion worksheets and if yes to notify them that they are going to lose their sheets with the migration and a link with the steps that they should follow in order to not lose their graphs.

@stratoula stratoula added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant NeededFor:KibanaApp Breaking Change labels Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

Hi @stratoula! Can you share how it can be detected if a user has any timelion worksheets?

@stratoula
Copy link
Contributor Author

Hey @alisonelizabeth! The server code that does it can be found here https://github.com/elastic/kibana/blob/master/src/plugins/timelion/server/plugin.ts#L32. We use the savedObjectsClient and try to find the type timelion-sheet. If sheets are found then we display the deprecation message on the server

@alisonelizabeth
Copy link
Contributor

Thanks @stratoula! Could you also include steps or link to documentation on the best way to set up Timelion sheets (for testing purposes)?

@stratoula
Copy link
Contributor Author

Sure, Navigate to <kibana_url>/app/timelion, then click the Save button that is on the upper right menu. You will see two options:

  • Save entire timelion sheet
  • Save current expression

Click the first one, give a name and the sheet is ready!

@alisonelizabeth
Copy link
Contributor

Hi @stratoula! Can this issue be closed now? This breaking change was registered via the new deprecations service in core in #94845.

It should display in Upgrade Assistant as follows (once #97159 is merged):

Screen Shot 2021-04-19 at 10 31 14 AM

Screen Shot 2021-04-19 at 10 31 22 AM

@stratoula
Copy link
Contributor Author

@alisonelizabeth you are definitely right! I am closing it, thank you for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants