Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Threshold rules should not add threshold_count to the main signal #82534

Closed
FrankHassanabad opened this issue Nov 3, 2020 · 0 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Feature:Threshold Rule Security Solution Threshold rule type fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0

Comments

@FrankHassanabad
Copy link
Contributor

Describe the bug:

When creating a threshold rule and setting the threshold_count, it should be copying its threshold_count into signal but remove/delete its threshold_count from the main document. During some goodness with refactoring I think this was accidentally dropped in 7.10.0.

When viewing a signal you can see that threshold_count is on the original record as well as within the signal.threshold_count when it should only exist within the signal.

Screen Shot 2020-11-03 at 3 52 54 PM

Steps to reproduce:

  1. Create a new threshold rule that triggers
  2. Look at the signal and notice it has two threshold_count's when it should only have one within signal

Current behavior:
Has a threshold_count at the main document level when it should not.

Expected behavior:
Should not have threshold_count at the main document level.

Kibana/Elasticsearch Stack version:
7.10.0

Server OS version:
any

Browser and Browser OS versions:
any

Elastic Endpoint version:
any

Original install method (e.g. download page, yum, from source, etc.):
any

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Detections Alerting

@FrankHassanabad FrankHassanabad added bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 3, 2020
@peluja1012 peluja1012 added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Nov 4, 2020
@MindyRS MindyRS added the Feature:Threshold Rule Security Solution Threshold rule type label Nov 17, 2020
@peluja1012 peluja1012 assigned madirey and unassigned marshallmain Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Detection Rules Security Solution rules and Detection Engine Feature:Threshold Rule Security Solution Threshold rule type fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0
Projects
None yet
Development

No branches or pull requests

6 participants