Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Grammatical error in validation message for threshold field Custom Rule Creation #81983

Closed
ghost opened this issue Oct 29, 2020 · 5 comments
Closed

[Security Solution] Grammatical error in validation message for threshold field Custom Rule Creation #81983

ghost opened this issue Oct 29, 2020 · 5 comments
Assignees
@banderror
Labels
bug Fixes for quality problems that affect the customer experience Feature:Custom Query Rule Security Solution Custom Query rule type Feature:Detection Rules Security Solution rules and Detection Engine fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v8.0.0

Comments

@ghost
Copy link

ghost commented Oct 29, 2020 •
edited by ghost
Loading

Describe the bug
Grammatical error in validation message for threshold field Custom Rule Creation

Build Details:

Elastic-Stack : 7.10.0 BC4
Commit: 3f7bbe02a2f08f0ad1c7f5a9b35235a4aa066a32
Build: 35887
Artifacts: https://staging.elastic.co/7.10.0-c650b297/summary-7.10.0.html

Browser Details
All

Preconditions

  1. Elastic Cloud 7.10.0 environment should be deployed
  2. Auditbeat should be running.

Steps to Reproduce

  1. Navigate to Create new rule under Security > Detection.
  2. Select Threshold card.
  3. Enter custom query: host.name: *
  4. Select as Field: host.name
  5. Select as Threshold 0
  6. Observe that "Value must be greater than or equal one" validation message is displaying instead of "Value must be greater than or equal to one."

Impacted Test case(s)
N/A

Actual Result
A grammatical error in validation message under threshold field when create threshold rule.

Expected Result
"Value must be greater than or equal to one." should be displayed under threshold field when create threshold rule.

What's Working
N/A

What's not Working
N/A

Screenshot:
threshold_validation_message
@ghost ghost added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 29, 2020
@ghost ghost assigned ghost and manishgupta-qasource Oct 29, 2020
@ghost
Copy link
Author

ghost commented Oct 29, 2020

@karanbirsingh-qasource Please review

@ghost ghost changed the title [Security Solution]"Value must be greater than or equal one" validation message is displaying instead of "Value must be greater than or equal to one." under threshold field when creating threshold rule. [Security Solution] Grammatical error in validation message under threshold field when create threshold rule. Oct 29, 2020
@ghost ghost changed the title [Security Solution] Grammatical error in validation message under threshold field when create threshold rule. [Security Solution] Grammatical error in validation message for threshold field Custom Rule Creation Oct 29, 2020
@ghost ghost assigned MadameSheema Oct 29, 2020
@ghost ghost added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

Reviewed and assigned to @MadameSheema

@MadameSheema MadameSheema added Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team labels Oct 30, 2020
@MadameSheema
Copy link
Member

@peluja1012 @spong can you please help to prioritise this? Thanks :)

@spong
Copy link
Member

spong commented Oct 30, 2020

This is a simple copy update that anyone on the team can quickly pick up -- adding to the 7.11 meta.

@spong spong added the v7.11.0 label Oct 30, 2020
@peluja1012 peluja1012 assigned banderror and unassigned peluja1012 and spong Nov 2, 2020
@MindyRS MindyRS added the Feature:Custom Query Rule Security Solution Custom Query rule type label Nov 17, 2020
@banderror banderror mentioned this issue Nov 30, 2020
Merged
2 tasks
@banderror
Copy link
Contributor

PRs:

-> 8.0.0 #84490
-> 7.11.0 #84642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

Labels
bug Fixes for quality problems that affect the customer experience Feature:Custom Query Rule Security Solution Custom Query rule type Feature:Detection Rules Security Solution rules and Detection Engine fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@peluja1012 @MindyRS @spong @banderror @MadameSheema @manishgupta-qasource