-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage Analytics on Saved Object Tags #81847
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
Is that the total number of tag objects that are at least assigned to 1 object?
The
Not sure about this one. @elastic/kibana-telemetry can you help us here?
atm we can't, Not sure how we can dissociate user created versus system created tags. We would need a 'createdBy' meta that I did not add.
TBH, I don't really know if we already have collectors that are doing 'per space' collection / distinction. I don't think we do? |
cc @elastic/kibana-telemetry could you take a look and check if the metrics suggested by @alexfrancoeur makes sense to you? Do you see anything we should avoid? Also, I see the kibana/src/plugins/kibana_usage_collection/server/collectors/kibana/get_saved_object_counts.ts Lines 54 to 63 in 9ca2238
Would we be forced to do the same for tag-related SO count metrics, or would it be alright to just perform calls to the SO apis?
Do you know if we already have per-space metrics / if that makes sense to have some here? |
Hey! Sorry for the late response! As @pgayvallet rightly mentioned, we already capture the number of SOs per type in the collector he shared. The output of that collector has the following structure:
Maybe we can extend it to report the number of tags per each type?
@pgayvallet this piece of logic was migrated from the Legacy codebase to KP. I'm not a big fan of using the raw index. However, when figuring out the implementation via the SO APIs, we found we might hit the pagination limit (10k docs max). It'd be great if the SO APIs allows aggregations of some sort.
AFAIK, the only space-related metrics are counting the number of spaces and the number of disabled features in them. But no SO-count per space apparently. |
@afharo thanks for the pointers
tags is an xpack / licensed feature. We can't use the same OSS collector here.
yea, I kinda figured that would be the answer. Performing such raw queries with the required filters gonna be harder than just filtering / aggregating by type though, so we might have to still use SO apis. Btw regarding aggregations for SOs: it's kinda planned, even if far from ready yet: #64002 |
These two indicators depends on the following metrics:
Which are already available from the I would go with the following data structure for the {
usedTags: number;
taggedObjects: number;
types: Record<string, { usedTags: number; taggedObjects: number;}>
} An example would be: {
usedTags: 3;
taggedObjects: 7;
types: {
dashboard: {
usedTags: 3;
taggedObjects: 5;
},
visualization: {
usedTags: 1;
taggedObjects: 2;
},
}
} |
++ that was my assumption as well. I don't think these need to be part of the tag usage collector but instead an analysis done in Kibana later on. What we need here is exactly what you've surface. The example provided LGTM. Thanks for jumping on this @pgayvallet ! |
Ok great. #83160 is ready then 😄 |
Relates to #79096 & #74571
As we introduce tags, it'll be great to understand how they are used. While I'm sure we can iterate here, there are some initial questions we'd like to answer. I realize it's late in the game to make this request, but given the long standing need for such content management mechanisms, it's be nice to capture usage metrics in 7.11 along with the tags themselves.
Number of tags
Questions we want answered
Metrics to help answer these questions
Number of tags by type
Questions we want answered
Metrics to help answer these questions
Open questions
cc: @joshdover @pgayvallet @ryankeairns , let me know what you think
The text was updated successfully, but these errors were encountered: