Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of the box, Kibana is unable to export and import all saved objects because of Canvas template #81560

Closed
rudolf opened this issue Oct 23, 2020 · 5 comments · Fixed by #83098
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@rudolf
Copy link
Contributor

rudolf commented Oct 23, 2020

Kibana version: 7.9.0+

  1. Fresh install of Kibana
  2. Export all saved objects from Management -> Saved Objects -> Export
  3. Try to restore your export by importing those objects

Importing fails because the exported file is > 11MB which is bigger than our default of 10MB for savedObjects.maxImportPayloadBytes. Almost all of this comes from the Canvas pitch presentation template: #69438

Although we want to keep savedObjects.maxImportPayloadBytes relatively low for security reasons we can probably bump it higher. However, putting static image data into a saved object doesn't seem like a good fit and when a single saved object is this large it can have negative effects on other parts of Kibana (slowing down saved objects management UI, making migrations more likely to fail).

Can't we move these large images that come with the default templates into x-pack/plugins/canvas/public/assets and serve them from /plugins/canvas/assets/{path*}?

@rudolf rudolf added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@rudolf
Copy link
Contributor Author

rudolf commented Oct 23, 2020

Related to #46819 and #36126 (comment). While we can increase the default limit to match canvas' old API (25MB) to allow users to create larger workpad templates, I don't believe kibana should ship with ~10MB saved objects out of the box.

@rudolf
Copy link
Contributor Author

rudolf commented Nov 3, 2020

Also worth mentioning that even if we increase the limit, this limit is not per object but per import file. So even if we increase the limit, if a user makes 3 copies of the default template they will again be unable to import their NDJSON file.

@clintandrewhall
Copy link
Contributor

@rudolf Would you consider this a duplicate of #66129 ?

@rudolf
Copy link
Contributor Author

rudolf commented Nov 3, 2020

Yes, closing in favour of #66129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants