Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] overlays.openConfirm: add capability to specify icon for confirm or cancel buttons #81482

Closed
pgayvallet opened this issue Oct 22, 2020 · 2 comments
Closed

[core] overlays.openConfirm: add capability to specify icon for confirm or cancel buttons #81482

pgayvallet opened this issue Oct 22, 2020 · 2 comments
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

Recent designs are displaying an icon in the 'confirm' button of confirmation modals

in example:

Screenshot 2020-10-22 at 15 28 27

EuiConfirmModal allow to pass a react element as cancelButtonText and confirmButtonText, however as core is framework agnostic, we decided to only allow string for these options, removing the possibility to customize the buttons labels.

Having an icon seems the most common enhancement. We should add confirmButtonIcon and cancelButtonIcon options to openConfirm.

An alternative would be to allow to pass a MountPoint for confirmButtonText / cancelButtonText, but this feels overkill.
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Oct 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet mentioned this issue Oct 22, 2020
Merged
@pgayvallet pgayvallet mentioned this issue Nov 9, 2020
Merged
6 tasks
@pgayvallet
Copy link
Contributor Author

We are going away from "framework-agnostic Core", so we won't need this anymore

@pgayvallet pgayvallet closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgayvallet @elasticmachine