Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] Kibana Global Navigation/Search Bar Terms #81352

Closed
Tracked by #83354
stephmilovic opened this issue Oct 21, 2020 · 8 comments
Closed
Tracked by #83354

[GS] Kibana Global Navigation/Search Bar Terms #81352

stephmilovic opened this issue Oct 21, 2020 · 8 comments
Labels
enhancement New value added to drive a business result Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@stephmilovic
Copy link
Contributor

Describe the feature:
When I use the global navigation search for the overall categories (Observability, Security, Kibana, Enterprise Search), I don't get the results I expect:

Screen Shot 2020-10-21 at 10 18 49 AM
Screen Shot 2020-10-21 at 10 18 36 AM

I feel like these search terms should either display the subpages of the category or the overview page for the category.
Screen Shot 2020-10-21 at 10 19 01 AM

Describe a specific use case for the feature:
Searching for Observability pages in the global nav currently returns no results. It should!

@myasonik myasonik added enhancement New value added to drive a business result REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@myasonik
Copy link
Contributor

I wonder if this could tie into either #76778 (each page gets a default keyword of their category?) or #72680 (is each feature group name searchable?)

@ryankeairns
Copy link
Contributor

ryankeairns commented Oct 21, 2020

My initial reaction is "Yes, this makes sense, we should do this.". Next, I contemplate if we ought to manage this in some central fashion (to avoid conflicts) or do we embrace the federated approach we have in place and simply allow authors to start claiming aliases/keywords in their registry definitions (this is essentially what #76778 is about).

If we're comfortable with the latter (which I think we are?), do we simply need to set some level of guidelines or expectations and encourage teams to just go forth?

cc:/ @alexfrancoeur

@pgayvallet
Copy link
Contributor

Returning applications of the categories matching the current search term could be done quite easily, and seems reasonable. However:

  • note that this solution would display ALL the apps from the category, not only the overview. (so we need to decide if that's what we want)

  • we would need to think a little about sorting/scoring, as apps can now be returned because either their name OR their category's name matches.

  • Also (probably minor but still) we would not be highlighting the matching term in the app's name, as it would match the category instead. Not sure the component allows to highlight on displayed 'meta', @myasonik?

Screenshot 2020-11-04 at 10 07 50

Other option, as suggested by Ryan, would be to consider that issue part of #76778 and let solutions implements their own keywords.

@ryankeairns
Copy link
Contributor

ryankeairns commented Nov 4, 2020

Thanks for explaining those potential side effects. My initial reaction is that this path will produce an undesirable UX where search becomes less predictable.

If I had $1 left to spend on the next feature, I keep coming back to the search syntax which seems to improve (and broaden) search in numerous ways. It could go so far as type: or even meta: (or description:), if so desired. This style of approach feels more intentional and predictable.

@pgayvallet pgayvallet added Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc REASSIGN from Team:Core UI Deprecated label for old Core UI team labels Oct 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka petrklapka changed the title Kibana Global Navigation/Search Bar Terms [GS] Kibana Global Navigation/Search Bar Terms Nov 6, 2023
@rshen91
Copy link
Contributor

rshen91 commented May 10, 2024

Tested on main - no longer an issue

@rshen91 rshen91 closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Navigational Search Global search bar Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

6 participants