Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time To Visualize] Unify Top Nav Between Lens & Visualize #81246

Closed
ThomThomson opened this issue Oct 20, 2020 · 1 comment · Fixed by #86922
Closed

[Time To Visualize] Unify Top Nav Between Lens & Visualize #81246

ThomThomson opened this issue Oct 20, 2020 · 1 comment · Fixed by #86922
Assignees
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Problem
Currently in Time to Visualize, there are a few small discrepancies in the top nav menus between the Lens and Visualize editors. These menus should be unified to present a consistent UX before the Time to Visualize project can be enabled by default.

Since the menu items on Lens have had design input, the visualize editor's menu items should be updated to match.

See this comment for further clarification
#72256 (review)

There are 4 possible menu states for a 'by value / by reference' enabled editor, 2 of which need to be updated.

  • Create by Value: When you've arrived at the editor from the 'create new' button in dashboard the save and return button should show to let the user know they can return to the dashboard easily. Additionally, a 'save to library' button provides an escape hatch for users to exit the 'by value' paradigm.

    Lens
    Screen Shot 2020-10-20 at 4 58 28 PM

    Visualize
    Screen Shot 2020-10-20 at 4 57 02 PM

  • Edit by Value: When you've arrived at the editor from the edit button on a by value dashboard panel, the menu should be the same as the 'create by value' use case. Showing the 'save to library' button:

    Lens
    Screen Shot 2020-10-20 at 5 08 21 PM

    Visualize
    Screen Shot 2020-10-20 at 5 08 59 PM

  • Create by Reference: When you've arrived at the editor from the 'create new' button in visualize the top nav menu the editors should look as they did in 7.8, with only an emphasized 'save' button. This menu state works fine and does not need to be updated.

  • Edit by Reference: When you've arrived at the editor from the edit button on a by reference dashboard panel. This meny state works fine and does not need to be updated.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:TimeToVisualize labels Oct 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants