Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: x-pack/test/api_integration/apis/ml/job_validation/cardinality·ts.apis Machine Learning job validation ValidateCardinality should recognize a high model plot cardinality #80418

Closed
spalger opened this issue Oct 13, 2020 · 4 comments · Fixed by #80617
Assignees
Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test :ml v7.11.0 v8.0.0

Comments

@spalger
Copy link
Contributor

spalger commented Oct 13, 2020

A failing ML test is preventing the promotion of a new 7.11 and master snapshot of ES.

Stacktrace

{ Error: expected [ { id: 'cardinality_model_plot_high',
    modelPlotCardinality: 4675 },
  { id: 'cardinality_partition_field',
    fieldName: 'order_id' } ] to sort of equal [ { id: 'cardinality_model_plot_high',
    modelPlotCardinality: 4711 },
  { id: 'cardinality_partition_field',
    fieldName: 'order_id' } ]
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/ml/job_validation/cardinality.ts:97:23)
  actual:
   '[\n  {\n    "id": "cardinality_model_plot_high"\n    "modelPlotCardinality": 4675\n  }\n  {\n    "fieldName": "order_id"\n    "id": "cardinality_partition_field"\n  }\n]',
  expected:
   '[\n  {\n    "id": "cardinality_model_plot_high"\n    "modelPlotCardinality": 4711\n  }\n  {\n    "fieldName": "order_id"\n    "id": "cardinality_partition_field"\n  }\n]',
  showDiff: true }

7.x/7.11: https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/1586/testReport//junit/X-Pack%20API%20Integration%20Tests/x-pack_test_api_integration_apis_ml_job_validation_cardinality%C2%B7ts/Kibana_Pipeline___kibana_xpack_agent___apis_Machine_Learning_job_validation_ValidateCardinality_should_recognize_a_high_model_plot_cardinality
master: https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/1587/testReport//junit/X-Pack%20API%20Integration%20Tests/x-pack_test_api_integration_apis_ml_job_validation_cardinality%C2%B7ts/Kibana_Pipeline___kibana_xpack_agent___apis_Machine_Learning_job_validation_ValidateCardinality_should_recognize_a_high_model_plot_cardinality

@spalger spalger added :ml failed-test A test failure on a tracked branch, potentially flaky-test failed-es-promotion v7.11.0 labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member

pheyos commented Oct 14, 2020

I've looked into this and tracked it down to some changing numbers of the ES cardinality aggregation. It seems there was an issue in the past where sometimes the numbers were not accurate and the new numbers look correct.

I've disabled the failing tests for now and will re-enable them with updated numbers after the ES snapshot promotion is done.

master: f6b01f5
7.x/7.11: 5281926

@pheyos
Copy link
Member

pheyos commented Oct 14, 2020

Turns out that there's another test that fails for the same reason and needs to be disabled.

master: 681c6ab
7.x/7.11: c0f7264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test :ml v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants