Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Rename positive rate to counter rate #80228

Closed
wylieconlon opened this issue Oct 12, 2020 · 6 comments
Closed

[TSVB] Rename positive rate to counter rate #80228

wylieconlon opened this issue Oct 12, 2020 · 6 comments
Assignees
@batchunag
Labels
Feature:TSVB TSVB (Time Series Visual Builder) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

We would like the Lens implementation of counter rate to match the TSVB implementation as much as possible, and after some discussion we've chosen a new name. Let's rename the TSVB function to match.
@wylieconlon wylieconlon added good first issue low hanging fruit Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week labels Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@batchunag
Copy link
Contributor

Let me try to work on this issue.

@wylieconlon
Copy link
Contributor Author

@batchunag Great, please update here if you are no longer working on this.

@batchunag batchunag mentioned this issue Oct 18, 2020
Merged
8 tasks
@batchunag
Copy link
Contributor

@wylieconlon I've made some changes. As I mentioned in the todo item on my PR, how do we proceed with the i18n translation?
In the guidelines, it was mentioned that only certain translators can contribute. Thanks.

@wylieconlon
Copy link
Contributor Author

@batchunag Thanks for the heads up. I see that @timroes has already given you some high level feedback which I agree with- if you have further questions let's move the discussion to your PR.

@timroes
Copy link
Contributor

timroes commented Nov 2, 2020

Closed via #80939

@timroes timroes closed this as completed Nov 2, 2020
@cyrille-leclerc cyrille-leclerc mentioned this issue Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batchunag batchunag

Labels
Feature:TSVB TSVB (Time Series Visual Builder) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wylieconlon @timroes @batchunag @elasticmachine