Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Duplicate labels on the filters or ranges aggregation result in missing data #80225

Closed
Tracked by #184459
wylieconlon opened this issue Oct 12, 2020 · 6 comments
Closed
Tracked by #184459
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

Scenario

  1. Create an XY chart
  2. Set the X axis to the filters agg, and create a filter with the label "A"
  3. Create a different filter with the label "A"
  4. Only one bar is shown with the label "A", where the second filter is excluded

Users can easily work around this issue by changing one of the names to be unique.

Open questions about what users intend

It's not clear what the expected behavior is, but it is likely one of these:

a. Users never want duplicate labels and expect Lens to assign unique names
b. Users never want duplicate labels and expect it to be an error
c. Users sometimes want duplicate labels, and they expect the data to be combined into the same name
d. Users sometimes want duplicate labels, and expect to see two sets of data with the same names

@wylieconlon wylieconlon added enhancement New value added to drive a business result loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

cc @AlonaNadler what do you think the expected behavior would be?

Duplicate labels might be meaningful if the difference is obvious from the context, e.g. a user could configure filters like this:

  • Traffic from China (geo.src:CN)
  • Excluding css (geo.src:CN AND NOT extension:css)
  • Traffic from US (geo.src:US)
  • Excluding css (geo.src:US AND NOT extension:css)
  • Traffic from DE (geo.src:DE)
  • Excluding css (geo.src:DE AND NOT extension:css)

But I'm not sure whether that's worth it (it's also technically harder to implement this than a validation that ensures unique names via option a. or option b.)

@AlonaNadler
Copy link

I think it's an edge case so be careful not to invest too much into it.
In general, I would allow users to have the same labels and show two sets of data with the same names

@flash1293
Copy link
Contributor

@AlonaNadler That's the most expensive option in terms of development effort. If we should solve it cleanly without investing too much, going with showing an error in the form seems like the easiest way.

@AlonaNadler
Copy link

I always had an expensive taste ;)

If we should solve it cleanly without investing too much, going with showing an error in the form seems like the easiest way.

sounds good

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Sep 6, 2023
@markov00
Copy link
Member

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box #184459

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants