Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime UI] Create new waterfall view #80162

Closed
katrin-freihofner opened this issue Oct 12, 2020 · 9 comments
Closed

[Uptime UI] Create new waterfall view #80162

katrin-freihofner opened this issue Oct 12, 2020 · 9 comments
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.11.0

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Oct 12, 2020

Describe the feature:

Wireframe

Step details v2

Headline

Showing the step name and details on the check (@drewpost please help me with these. You mentioned device type and connection details)

Screenshot 2020-10-12 at 15 49 23

Metrics

Screenshot 2020-10-12 at 15 49 49

  • First byte
  • Start render
  • First contentful paint
    ... @drewpost I can not find the list of Metrics we want to show anymore - do you have it somewhere?

Waterfall

Screenshot 2020-10-12 at 15 50 22

  • Every row is the same height
  • The full waterfall should fit horizontally
  • the colored bars indicate the time spent
  • The colors indicate the MIME type (they should always be the same in Synthetics, please use our visualization colors. These colors must not be assigned as I'm showing them here, feel free to pick different ones)
  • every row shows a label with the resource name (these URLs could be very long, please make sure the start and end are readable). We should define a min. width for the labels and move them to the left once there is too little space on the right.
  • please move the labels on small screens inside the colored boxes
  • show error indicator highlighted with a badge for all 4xx, 5xx, 301, 307, and 308 response codes
  • there should be indicators for start render, visually complete, page load, time to interactive, DOM content loaded, @drewpost do you have a full list for these?
  • the waterfall itself should scroll separately (indicators stay visible even if user scrolls down)
  • Legend, sticky on the bottom of the waterfall
  • when hovering over the waterfall, a vertical line should indicate the time/duration at this point (green line in wireframes)
  • there are up to two buttons at the very top, to download the full script and the full DOM (only for last step). Please add telemetry support to both buttons.

Please make sure the waterfall view is linked from the check details (#80156), the monitor details view and the overview.

Next steps (handled in different issues, check meta issue for further details)

  • click interaction on rows in waterfall triggers flyout and show details
  • filter capabilities to waterfall
  • step selector to waterfall
  • next/previous check buttons to waterfall
  • charts to waterfall
  • hover interaction to all screenshots

Figma file

@katrin-freihofner katrin-freihofner added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@drewpost
Copy link

@katrin-freihofner This seems to be missing the connection steps on the objects (ie DNS, SSL etc)

@paulb-elastic
Copy link
Contributor

@katrin-freihofner it's also worth mentioning that not all bar segments will necessarily be touching, as you can have gaps between different parts of the network request, something like this:
image

@katrin-freihofner
Copy link
Contributor Author

@katrin-freihofner This seems to be missing the connection steps on the objects (ie DNS, SSL etc)

@drewpost
It was not mentioned in the design issue. Can you provide more details?

@drewpost
Copy link

Hey @katrin-freihofner - As discussed on our call today, you'll add in the four components to these lines: DNS, connect, SSL/TLS and time to first byte for all objects that we hold data for. This may not be all objects on the page as this cost is only incurred for the first connection to the domain (or at least, it should be!)

@paulb-elastic
Copy link
Contributor

As discussed in refinement, until #80156 is implemented, we will include a link from the existing details view, to the waterfall chart via a text/image link (@formgeist mentioned that APM have a waterfall/trace icon that might be suitable)

@formgeist
Copy link
Contributor

There's the apmTrace glyph in EUI which displays like a waterfall visualization. We might consider renaming this glyph to "waterfall" to be more generic in its wording.

Screenshot 2020-11-19 at 16 40 55

@paulb-elastic
Copy link
Contributor

As discussed in refinement, we will remove the current vertical annotation bar that is snapping to the end of a timing point, as we will look to make use of a more precise pixel version when we work on the filmstrip and scrubber (#83816).

@paulb-elastic
Copy link
Contributor

The main waterfall chart has been implemneted.

Items in the original spec that have not yet been implemented are covered in separate issues:

@andrewvc andrewvc added the test-plan-ok issue has passed test plan label Dec 17, 2020
@andrewvc andrewvc self-assigned this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.11.0
Projects
None yet
Development

No branches or pull requests

7 participants