Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Query string input - ARIA Role missing required child elements #79927

Closed
barlowm opened this issue Oct 7, 2020 · 6 comments
Closed
Labels
Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A

Comments

@barlowm
Copy link
Collaborator

barlowm commented Oct 7, 2020

Steps to reproduce

Navigate to any query string input. One example is found on Lens:

  1. From Kibana Home Page, use the side navigation bar to navigate to the "Visualize" page
  2. Click the "Create visualization" button
  3. Click the "Go to Lens" button

Errors

  • Search combo box has role="combobox" but no reference to what the contents of the combobox should be.
  • The child `role="listbox" also need an accessible name.

MissingRequired

Relevant WCAG Criteria

Relevant ARIA spec
3.14 Listbox - A listbox widget presents a list of options and allows a user to select one or more of them. A listbox that allows a single option to be chosen is a single-select listbox; one that allows multiple options to be selected is a multi-select listbox.

@barlowm barlowm changed the title (Accessibility) ARIA Role missing required child elements (Accessibility) Visualization/Lens - ARIA Role missing required child elements Oct 7, 2020
@wylieconlon wylieconlon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

This is a shared component, not a Lens-specific one. Going to update the labels and description

@wylieconlon wylieconlon changed the title (Accessibility) Visualization/Lens - ARIA Role missing required child elements (Accessibility) Query string input - ARIA Role missing required child elements Oct 12, 2020
@wylieconlon wylieconlon added Feature:Query Bar Querying and query bar features Team:AppArch and removed Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@myasonik myasonik added the loe:x-large Extra Large Level of Effort label Oct 30, 2020
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Mar 9, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:weeks and removed loe:x-large Extra Large Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:x-large Extra Large Level of Effort and removed loe:weeks labels Jan 4, 2022
@petrklapka petrklapka added Feature:Search Querying infrastructure in Kibana Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Search Querying infrastructure in Kibana Feature:Query Bar Querying and query bar features Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 23, 2024
@barlowm
Copy link
Collaborator Author

barlowm commented Aug 30, 2024

Can be closed as issue not longer presents itself in current version of Kibana (ver Kibana-8.13.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
None yet
Development

No branches or pull requests

8 participants