Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search.aggs] Use point in time searches for "Other" bucket #79863

Closed
Tracked by #166068
wylieconlon opened this issue Oct 7, 2020 · 6 comments
Closed
Tracked by #166068

[data.search.aggs] Use point in time searches for "Other" bucket #79863

wylieconlon opened this issue Oct 7, 2020 · 6 comments
Labels
Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:AsyncSearch Background search, partial results, async search services. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@wylieconlon
Copy link
Contributor

The point in time API would prevent potential edge cases in the "Other" bucket by executing sequential requests using the same context. This would be especially useful for handling slow queries with updates happening in between, a situation that can cause inaccurate results today.

It is likely that we would need to implement this as part of the search strategies repository, so that the fallback case when the point in time API is not available is to run searches normally.

cc @lizozom @lukasolson

@wylieconlon wylieconlon added Feature:Search Querying infrastructure in Kibana Team:AppArch Project:AsyncSearch Background search, partial results, async search services. labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson
Copy link
Member

I'm curious if we have any idea of the performance impact creating a PIT has on a search request. Do we have any data comparing two serial requests without PIT to the same using PIT? Or even creating the PIT itself?

@wylieconlon
Copy link
Contributor Author

That question would best be answered by @dnhatn or @jimczi

@dnhatn
Copy link
Member

dnhatn commented Oct 7, 2020

@wylieconlon @lukasolson Thank you for working on it.

I'm curious if we have any idea of the performance impact creating a PIT has on a search request.

A point in time is created in a separate step, and that step should be fast.

Do we have any data comparing two serial requests without PIT to the same using PIT?

The overhead of PIT in a search is trivial. We don't expect any performance impact with PIT. If any, then we will address it.

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:large Large Level of Effort and removed loe:small Small Level of Effort labels May 19, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson
Copy link
Member

Somewhat related: #88480

@kertal kertal added the Icebox label Oct 30, 2023
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@github-project-automation github-project-automation bot moved this to Done in current release in kibana-app-arch Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:AsyncSearch Background search, partial results, async search services. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
Status: Done in current release
Development

No branches or pull requests

6 participants