Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] File upload card sometimes missing on Kibana home page #78965

Closed
pheyos opened this issue Sep 30, 2020 · 3 comments · Fixed by #79080
Closed

[ML] File upload card sometimes missing on Kibana home page #78965

pheyos opened this issue Sep 30, 2020 · 3 comments · Fixed by #79080
Assignees
Labels
bug Fixes for quality problems that affect the customer experience :ml regression

Comments

@pheyos
Copy link
Member

pheyos commented Sep 30, 2020

Sometimes, the Kibana home page doesn't display the Upload a file button even though the user has the needed permissions.
image

Can e.g. be seen a couple times in this flaky test runner job.

Might be related to the changes made in #77745

@pheyos pheyos added bug Fixes for quality problems that affect the customer experience :ml labels Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Sep 30, 2020

This issue makes the functional permission tests fail, so I've disabled them until this issue is solved:

master: 1b26c90
7.x/7.10: a9c0969

@walterra
Copy link
Contributor

walterra commented Oct 1, 2020

Some investigation:

  • registerFeature() adds the file import panel on Kibana's home page.
  • In ml/plugin.ts this has always been called in the callback for the license subscription (an async callback).
  • With the changes in [ML] Limit exposing shared static code through ml/public/index.ts. #77745 we added remote data fetching to reduce the bundle size of the page load bundle. This increases the time it might take to get to the code that does the registers. This results in a race condition which triggers the failing test.
  • It is worth noting that the overall structure of the code (registering in an async function after the license check triggers). It seems to me until now we've just been lucky enough that this wasn't triggered.

This investigation is still work in progress, will further dig down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :ml regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants