Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run build for functional tests outside Kibana root #78959

Closed
tylersmalley opened this issue Sep 30, 2020 · 3 comments
Closed

Run build for functional tests outside Kibana root #78959

tylersmalley opened this issue Sep 30, 2020 · 3 comments
Assignees
@brianseeders
Labels
Team:Operations Team label for Operations Team

Comments

@tylersmalley
Copy link
Contributor

tylersmalley commented Sep 30, 2020 •
edited
Loading

Currently, we run pass --kibana-install-dir to the functional test server with a path to the build directory. If a required dependency is not present in the build, Node will continue walking up the tree until it finds it. This can happen if a dependency is only defined as a devDependency and used server-side.

Related to #78941
@tylersmalley tylersmalley added the Team:Operations Team label for Operations Team label Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Copy link
Contributor

spalger commented Sep 30, 2020

I swear we've fixed this like three times in the past 😅

@tylersmalley
Copy link
Contributor Author

Fixed in #80018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianseeders brianseeders

Labels
Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tylersmalley @brianseeders @spalger @elasticmachine