[GS] Make the keyboard shortcut customizable

[ryankeairns]

The keyboard shortcut has changed more than once since we've started working on this feature. It has been challenging to find a solution that does not conflict with one of the major browsers or screen readers. Given the wide range of possible conflicts - many which very per user - our belief is that this should be customizable via Advanced Settings.

In addition to the advanced setting, we also have on our roadmap the creation of a global keyboard shortcut registry to avoid conflict within our own applications as shortcut usage continues to grow.

[elasticmachine]

Pinging @elastic/kibana-core-ui (Team:Core UI)

[myasonik]

Is this worth adding as an advanced setting now just to be usurped by the global keboard shortcut registry down the road?

One is significantly easier than the other but it's still duplicate work that will cannibalize itself which seems unfortunate.

[ryankeairns]

Based upon experience and feedback thus far (and its not even shipped), I think it would be wise to add the advanced setting rather than wait for the shortcut registry.

[formgeist]

+1 for adding a custom shortcut option in advanced settings. Europeans most likely won't be able to do / easily because the keyboard shortcut is Shift + 7.

[ryankeairns]

This feels like a necessary item to prioritize in the near term. I've moved it to the 'planned' category, as such.

cc:/ @alexfrancoeur @myasonik

[myasonik]

@ryankeairns Are you thinking we tackle just customizing this specific keyboard shortcut or tackle the wider issue of registering and customizing keyboard shortcuts across Kibana broadly?

The former would be quicker and easier. But long-term we'll still need to solve the broad issue which will cause some duplicate work.

The latter we'll probably need significant support from the Core or App Services teams so it's bigger not just technically but also organizationally. (But then we only have to do the work once.)

[ryankeairns]

@ryankeairns Are you thinking we tackle just customizing this specific keyboard shortcut or tackle the wider issue of registering and customizing keyboard shortcuts across Kibana broadly?

The former would be quicker and easier. But long-term we'll still need to solve the broad issue which will cause some duplicate work.

The latter we'll probably need significant support from the Core or App Services teams so it's bigger not just technically but also organizationally. (But then we only have to do the work once.)

This one feels like a rather immediate need in that the current situation likely affects a significant swath of people. In this case, I think it's worth doing the quick approach as the bigger topic is not very well-defined and, thus, is not yet on the radar for other teams.

[ryankeairns]

Actually, it may be best to tackle this with the upcoming personalization work as this seems like a rather obvious per user setting.

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)