Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] [Discuss] Add Lens to navigational search results #77218

Closed
ryankeairns opened this issue Sep 10, 2020 · 6 comments · Fixed by #77448
Closed

[GS] [Discuss] Add Lens to navigational search results #77218

ryankeairns opened this issue Sep 10, 2020 · 6 comments · Fixed by #77448
Labels
discuss REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 10, 2020

Relates to #72680 #72331

Describe the feature:
The first iteration of navigation search returns apps and saved objects. Currently, Lens is treated like a feature/type within Visualize thus it does not appear in search results.

Describe a specific use case for the feature:
User wants to create a visualization with Lens, so they search for it...

... however, there are product and technical considerations that come with this addition:

  • We're moving towards a Dashboard-first approach; this may promote a Lens-first workflow
  • Lens is not a top level nav item, so this addition would depart from the 1:1 (apps in nav results) relationship
  • It would require some custom work for this to be displayed

(I'm sure there are more, but this gets the conversation started)

cc:/ @myasonik @alexfrancoeur @pgayvallet @joshdover @AlonaNadler

@ryankeairns ryankeairns added discuss REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Sep 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

As discussed on slack,

lens is hidden in the navigation, and we decided to exclude hidden apps from search results (to avoid returning the login page app for example, or app disabled/hidden because of permissions) We already discussed about a way to manually opt in/out applications from the GS results when the app is registered, but as this meant adding an additional option to app registrations that would only be used in xpack by GS, we didn't do it for now.

@alexfrancoeur
Copy link

This feels like it's related to our next planned iteration of search that provides more granular feature results #72680

@AlonaNadler
Copy link

If there isn't any technical aspect holding this back. I agree with Ryan that it will be good to allow users to jump to Lens using the global search

@flash1293
Copy link
Contributor

flash1293 commented Sep 15, 2020

I checked out the code and as there is a public API to register new search providers, nothing should stop us from adding a Lens entry in there in 7.10. I will set up a PR. We should revisit the code when tackling #72680 - if you decide to go that route I will add a note to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants