Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actions] Pager Duty action uses the same default dedupkey for all Alerts when resolving #76908

Closed
gmmorris opened this issue Sep 8, 2020 · 1 comment · Fixed by #77773
Closed

[Actions] Pager Duty action uses the same default dedupkey for all Alerts when resolving #76908

gmmorris opened this issue Sep 8, 2020 · 1 comment · Fixed by #77773
Assignees
@gmmorris
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

gmmorris commented Sep 8, 2020 •
edited
Loading

PagerDuty Action can open an incident once an Alert Instance is triggered and it can also be configured to close an incident (which will be useful when deliver #49405), but it uses the actionId as the default dedupkey which means the same key is used for all actions of the same connector - this is a problem as it means all actions will act on the same incident by default.

kibana/x-pack/plugins/actions/server/builtin_action_types/pagerduty.ts

Line 235 in c7dac80

const dedupKey = params.dedupKey || `action:${actionId}`;

@gmmorris gmmorris mentioned this issue Sep 8, 2020
Open
@mikecote mikecote mentioned this issue Sep 8, 2020
Open
59 tasks
@mikecote mikecote added blocked Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris changed the title [Actions] Pager Duty action doesn't close an incident when an Alert Instance resolves [Actions] Pager Duty action uses the same default dedupkey for all Alerts when resolving Sep 9, 2020
@gmmorris gmmorris added bug Fixes for quality problems that affect the customer experience and removed blocked labels Sep 9, 2020
@gmmorris gmmorris self-assigned this Sep 17, 2020
This was referenced Sep 17, 2020
Closed
Merged
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmmorris gmmorris

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Actions] avoids setting a default dedupKey on PagerDuty gmmorris/kibana
4 participants
@gmmorris @kobelb @mikecote @elasticmachine