Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill sidebar animation and change main container width instead of translating it #7674

Closed
cjcenizal opened this issue Jul 8, 2016 · 4 comments

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 8, 2016

Currently hovering over the sidebar triggers a translation animation of the main container, which moves it to the right. This reveals the text for the links in the sidebar, and causes the right-most content in the main container to be clipped by the right side of the window.

Per discussion with @uboness and @alt74 , let's remove this animation and make the change immediate. Also, instead of translating the main container, let's change its width instead. This will cause a redraw of its content, but will prevent the content from being clipped.

Related to #7467 and #7665 (allow pinning of sidebar).

@cjcenizal cjcenizal self-assigned this Jul 8, 2016
@epixa
Copy link
Contributor

epixa commented Jul 8, 2016

The redraw of content is way worse than the content being clipped. It will, for example, result in all visualizations on the page rebuilding, which is both expensive and disruptive. Crack open 4.x, create a dashboard with a ton of visualizations, and then change your browser window size by a pixel or two, and you'll get the idea.

If the navbar has an explicit toggle so it will stay expanded, then it makes sense to resize, but for any mouseover animation, we shouldn't be resizing anything.

@Bargs
Copy link
Contributor

Bargs commented Jul 8, 2016

I agree with @epixa, a full page redraw is really jarring and will be painfully slow on complex screens.

@kimjoar
Copy link
Contributor

kimjoar commented Jul 11, 2016

Very much agree on clipping being the best choice. Having to redraw can cause a whole lot of issues depending on the content. I don't see any problem with the content temporarily being off-screen — it's not the focus either way, the focus is the navigation.

@cjcenizal
Copy link
Contributor Author

Addressed by #7723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants