Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Move stats collector back into the monitoring plugin #76230

Closed
chrisronline opened this issue Aug 28, 2020 · 2 comments
Closed

[Monitoring] Move stats collector back into the monitoring plugin #76230

chrisronline opened this issue Aug 28, 2020 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Telemetry Team:Monitoring Stack Monitoring team

Comments

@chrisronline
Copy link
Contributor

#62665 introduced a weird relationship between Kibana monitoring and telemetry when we moved the kibana_stats collector outside of monitoring and into the telemetry plugin. This collector is responsible to collect Kibana monitoring metrics, which we then ship to the monitoring cluster. Unfortunately, by moving the collector into the telemetry plugin, it means that one could disable the telemetry plugin and it essentially breaks Kibana monitoring.

#65663 unintentionally fixed this issue by moving it to another plugin, but we still have the same issues.

I understand that we wanted to move the stats collector into a pure OSS environment, but it presents an awkward situation where a seemingly random plugin is disabled and Kibana monitoring breaks.

I think we need to move this back into the monitoring plugin and take another pass at how to handle the OSS issue.

@chrisronline chrisronline added bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team Feature:Telemetry labels Aug 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@afharo
Copy link
Member

afharo commented Jan 25, 2021

I think we can close this issue. #83546 already removed that dependency :)

@chrisonline, feel free to reopen if you feel otherwise.

@afharo afharo closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Telemetry Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants