Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Add links and fix problems found during UI text edits #75807

Closed
3 of 5 tasks
dedemorton opened this issue Aug 24, 2020 · 3 comments
Closed
3 of 5 tasks
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@dedemorton
Copy link
Contributor

dedemorton commented Aug 24, 2020

We found these issues when we were editing the UI text (#74818), but I didn't want to fix them in that PR because they changed behavior (not just text):

@dedemorton dedemorton added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph assigned skh Aug 24, 2020
@skh skh changed the title Add links and fix problems found during UI text edits [Ingest Manager] Add links and fix problems found during UI text edits Aug 25, 2020
@skh
Copy link
Contributor

skh commented Aug 27, 2020

Hi,

Make "Gold subscription" an active link in the text "Requires a Gold subscription."

I'm having a UX issue with this one. Right now, this is how the settings flyout looks like with a basic license:
image

The disabled option is not clickable, and the cursor clearly indicates that when hovering over the label text. I'm not sure if nudging a link into that place is a good solution (if it's possible at all with the EUI component that's used), but I'm also not sure where and how else to indicate that this setting needs a gold subscription.

@hbharding I could use your help here -- what do you think? Do we have some canonical way of marking specific settings as needing a higher subscription level?

@skh
Copy link
Contributor

skh commented Sep 2, 2020

I've added new issues for the first and fourth item in the list. The others are implemented in #76284.

Once that is merged, I'll close this issue.

@skh skh closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants