Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config data needs to be encoded when embedded in html so you cannot inject scripts #7566

Closed
epixa opened this issue Jun 28, 2016 · 1 comment

Comments

@epixa
Copy link
Contributor

epixa commented Jun 28, 2016

This hasn't been released yet, but at the moment the alpha4 builds allow for script injection via configuration values from advanced settings. You should be able to trigger it by adding the following as the value for any non-json config value:

</script><script>alert('nooooo');</script>
@epixa
Copy link
Contributor Author

epixa commented Jun 28, 2016

I reverted that PR because it doesn't pass tests (locally or on CI), so this is still an open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants