Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] [ML] DF Analytics map #75295

Closed
43 of 48 tasks
alvarezmelissa87 opened this issue Aug 18, 2020 · 6 comments
Closed
43 of 48 tasks

[Meta] [ML] DF Analytics map #75295

alvarezmelissa87 opened this issue Aug 18, 2020 · 6 comments
Assignees
Labels

Comments

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Aug 18, 2020

Meta issue for DF Analytics map

General

  • Add Map tab to analytics management view
  • Map tab should persist until new job/model is selected (will need to persist selected jobId/modelId for map)
  • Endpoints should use new es client
  • switch 'inference model' node type to 'trained model'
  • Support for dark theme
  • Format create time to human readable
  • Handle source index pattern with wildcard
  • Should be space aware
    • Should only show jobs and indices that exist in the same space as the root job/model
  • Can link to map just with url (so it’s share-able)
    • _g=(ml:(jobId:classification-clientip-04,analysisType:classification,isMap:true))
    • add new endpoints to apidoc.json
    • add modelId in url params to start map from model

Map

Tests

  • Add functional tests
  • Add API integration tests

Code level

  • use url generator for map url
  • move away from using dependency cache for toasts (in job map component)

Known issues to fix

  • When model's job has been deleted and map is started from the model's list nothing is returned. One node for that model should be returned. Or the map action should be disabled. ([ML] Data frame analytics: Adds job deletion and creation to map view #84299)
  • When scrolling in the flyout, the cytoscape window also zooms in/out - that shouldn't happen
  • When in map tab, the Refresh button is in loading state
    image
  • cytoscape options - background image property needs a default icon to avoid console warnings
  • Flyout cannot be re-opened until selected node gets deselected
  • When there is only one "row" of nodes (e.g. not multiple related jobs that are distributed vertically), the graph ends up at the top of the visible area and is cut off
  • With narrow nodes the labels get hidden when there are many leaf nodes from one parent node.
  • Double scrollbar

Screenshots

image

image

image

@alvarezmelissa87 alvarezmelissa87 added Meta :ml Feature:Data Frame Analytics ML data frame analytics features labels Aug 18, 2020
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

peteharverson commented Oct 30, 2020

Feedback from testing of #81666:

  • Format the create_time in the flyout as a date / time
  • Add ability to create new DFA jobs off nodes in the map e.g. select transform node, and create classification job off the index created by the transform
  • Add 'Fit to page' (or 'reset zoom') button to the map - I often find myself zooming in / out by accident and then want to reset to the default zoom level
  • Is it possible to include the different types of DFA job in the legend, rather than just have the one circular job for analytics jobs?
  • Add the transform / DFA job description and DFA job type to the flyout
  • Is it possible to reduce the minimum spacing between nodes? For example, here why is the text for the last node not vertically aligned with the other nodes?

image

@walterra
Copy link
Contributor

walterra commented Nov 5, 2020

Looks like switching to a horizontal layout is definitely an improvement! With narrow nodes the labels tend to get hidden though.

image

Suggestions:

  • Maybe cytoscape supports positioning labels to the right of nodes (would also left-align the text and make lots of nodes of different length easier to read)
  • An alternative could be to hide labels if there are more than a certain threshold (similar to how nodes are hidden when zooming out) and showing labels only on hover then.

@walterra
Copy link
Contributor

walterra commented Nov 5, 2020

When there is only one "row" of nodes (e.g. not multiple related jobs that are distributed vertically), the graph ends up at the top of the visible area and is cut off:

image

@peteharverson
Copy link
Contributor

I noticed when testing #84299 that if you decrease the size of the window after the initial render that the overflow isn't scrollable. Is this a known issue / 'feature' with Cytoscape?

image

@alvarezmelissa87
Copy link
Contributor Author

All left over items have been moved to a follow up meta issue: #86487

Please add any additional feedback there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants