Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: API Integration Tests.test/api_integration/apis/telemetry/telemetry_local·js - apis Telemetry /api/telemetry/v2/clusters/_stats should pull local stats and validate data types #74625

Closed
kibanamachine opened this issue Aug 9, 2020 · 6 comments · Fixed by #74664
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: expected 0 to be above 0
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.greaterThan.Assertion.above (packages/kbn-expect/expect.js:317:8)
    at Function.greaterThan (packages/kbn-expect/expect.js:531:15)
    at Context.it (test/api_integration/apis/telemetry/telemetry_local.js:93:61)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo self-assigned this Aug 10, 2020
@afharo
Copy link
Member

afharo commented Aug 10, 2020

After looking at the logs, it looks as if ES had some storage problem/delays during the execution of this test: The failed assertion is

expect(stats.stack_stats.data[0].size_in_bytes).to.be.greaterThan(0);

The assertion is related to the index "filebeat-telemetry_tests_logs" created in the before step.

If preferred, we could replace .to.be.greaterThan(0); and use .to.be.a('number'); instead so this won't happen again. But these changes were merged and backported 1+ month ago (#70557) and it's the first and only time it happened.

What do you think @dmlemeshko?

@dmlemeshko
Copy link
Member

@afharo I think test adjustment is a better option, but only if it is still valid after a change.
Is it a valid case when size is zero bytes?

@afharo
Copy link
Member

afharo commented Aug 10, 2020

Is it a valid case when size is zero bytes?

To be fair, we are only creating the index (not storing any document in it), so the size is expected to be minimal (208 bytes in my Mac). It seems weird to be 0 (AFAIK, the index should take a bit of space), but I guess it's fine to simply check it's a number. I'll create a tentative PR with the change 👍

@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants