Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Upgrade Apollo dependencies #73574

Closed
2 tasks
rylnd opened this issue Jul 28, 2020 · 10 comments
Closed
2 tasks

[Security Solution] Upgrade Apollo dependencies #73574

rylnd opened this issue Jul 28, 2020 · 10 comments
Assignees
Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.11.0

Comments

@rylnd
Copy link
Contributor

rylnd commented Jul 28, 2020

We need to update our Apollo/GraphQL code to support #71393.

Broad goals:

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd
Copy link
Contributor Author

rylnd commented Jul 28, 2020

Current status: I have a spike branch here that begins this work. I've removed GraphiQL for now but we can add it back if needed.

I started fixing typescript errors related to our use of runHttpQuery but realized there are runtime errors preventing kibana from starting, so I'm currently looking into those.

@patrykkopycinski
Copy link
Contributor

Here is my old PR that maybe you will find helpful https://github.com/elastic/kibana/pull/58974/files#diff-84dba1d472f9e06c0896acd55b201204

@rylnd
Copy link
Contributor Author

rylnd commented Aug 6, 2020

Quick update: it seems like the team consensus is that the effort required here would be better invested in removing GraphQL entirely. I believe @XavierM will be working on this in 7.10; when we have a public issue I'll link that and close this.

@XavierM
Copy link
Contributor

XavierM commented Aug 7, 2020

The goal is to try to remove our graphql in 7.10, but we can not promise to get all out it for 7.10. Let's see.

@rylnd rylnd added v7.11.0 and removed v7.10.0 labels Oct 8, 2020
@rylnd
Copy link
Contributor Author

rylnd commented Oct 8, 2020

Moving this to (at least) 7.11. We've moved much of our querying to use search strategies and remove our dependence on apollo, but we have a few outstanding graphql queries that depend on retrieval of saved objects, which existing search strategies do not support. I was unable to find an issue for said SO support; @XavierM, please link that issue here if/when it's created, and please correct any inaccuracies above.

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
@rylnd
Copy link
Contributor Author

rylnd commented Nov 30, 2020

Update: a saved objects client is now available within search strategy handlers as of #80775. This should unblock the migration of timeline endpoints.

@angorayc
Copy link
Contributor

angorayc commented Mar 9, 2021

We replaced most of our graphQL endpoints in previous release, some with http endpoints and some with search strategy. I'm working on this in 7.13, and these are the graphQL we still have:

  1. Notes - x-pack/plugins/security_solution/server/graphql/note/resolvers.ts
  2. Timelines - x-pack/plugins/security_solution/server/graphql/timeline/resolvers.ts
  3. PinnedEvents - x-pack/plugins/security_solution/server/graphql/pinned_event/resolvers.ts
  4. Hosts - x-pack/plugins/security_solution/server/graphql/hosts/resolvers.ts

#95036

@angorayc
Copy link
Contributor

GraphQL is removed in 7.13.

@jportner
Copy link
Contributor

We completely removed the apollo-server-core package in the PR linked above, so this issue can be closed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.11.0
Projects
None yet
Development

No branches or pull requests

7 participants