Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test needed for exercising attachment upload timeouts #73557

Closed
FrankHassanabad opened this issue Jul 28, 2020 · 1 comment · Fixed by #73730
Closed

Unit test needed for exercising attachment upload timeouts #73557

FrankHassanabad opened this issue Jul 28, 2020 · 1 comment · Fixed by #73730
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@FrankHassanabad
Copy link
Contributor

FrankHassanabad commented Jul 28, 2020

As per this PR and discussion:
#73103 (comment)

router.test.ts needs a unit test (if possible) to be able to timeout when doing an upload and showing off a 408 Request timeout or a socket hangup when the timeout is exceeded. The tests right now exercise the server side timing out after the payload from the PUT/POST has reached the server but we don't have an integration/unit test which shows the 408 Request timeout happening after a socket connection starts and then the upload delays or goes so slowly that the server disconnects and. gives a 408 or socket hangup when the timeout is small.

Kibana version:
7.9.0, 7.10.0

@FrankHassanabad FrankHassanabad added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jul 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants