Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] When editing visualization with session storage on, compressed URL is lost #73046

Closed
majagrubic opened this issue Jul 23, 2020 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@majagrubic
Copy link
Contributor

majagrubic commented Jul 23, 2020

Kibana version:
7.9 BC2

Original install method (e.g. download page, yum, from source, etc.):
Cloud

Describe the bug:
I believe the root cause is the same as #73013, but putting it here just in case it isn't.
When editing a visualization that was added through an "Add option", if state:storeInSessionStorage advanced setting is turned on, the URL defaults to a long one.

Steps to reproduce:

  1. Go to Advanced settings
  2. Turn on state:storeInSessionStorage setting
  3. Reload the page; make sure the setting is applied
  4. Select "Add" and add an existing visualization
  5. Edit existing visualization
  6. Observe the changed URL

Expected behavior:
URL stays compressed

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@majagrubic majagrubic changed the title [Dashboard] When editing visualization with session storage on, we default back to regular URL [Dashboard] When editing visualization with session storage on, compressed URL is lost Jul 23, 2020
@majagrubic majagrubic added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@majagrubic majagrubic added Feature:Dashboard Dashboard related features bug Fixes for quality problems that affect the customer experience labels Jul 23, 2020
@majagrubic
Copy link
Contributor Author

majagrubic commented Jul 23, 2020

Also, when sharing a dashboard via permalink a regular URL is generated.

@Dosant
Copy link
Contributor

Dosant commented Jul 23, 2020

Also, when sharing a dashboard via permalink a regular URL is generated.

afaik, this is expected.
Otherwise sharing won't makes sense because state won't be stored in the url.

@flash1293
Copy link
Contributor

True, @Dosant . Also, short url should handle it gracefully (without putting everything in the URL at any point)

@majagrubic
Copy link
Contributor Author

Sorry, I am on vacation this week and away from computer, but I am pretty sure I checked this on 7.8 and it worked differently. Would either one of you mind verifying this and then closing it if it's not an issue? 🙏 @flash1293 @Dosant

@majagrubic
Copy link
Contributor Author

Ah sorry, for permalinks you are right - it is indeed the expected behavior.
But the original issue of losing compressed URL when editing visualization isn't.

@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Mar 6, 2021
@kmartastic
Copy link
Contributor

@ThomThomson you have a sense of LOE on this?

@ThomThomson
Copy link
Contributor

I am unable to recreate this in Master, the compressed URL is retained throughout adding panels, editing panels etc. Will close for now, and we can reopen if this issue crops up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants