Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate data folder creation to core #73002

Closed
pgayvallet opened this issue Jul 23, 2020 · 1 comment · Fixed by #75527
Closed

Migrate data folder creation to core #73002

pgayvallet opened this issue Jul 23, 2020 · 1 comment · Fixed by #75527
Assignees
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

The data folder creation is currently done from the kibana legacy plugin

preInit: async function (server) {
try {
// Create the data directory (recursively, if the a parent dir doesn't exist).
// If it already exists, does nothing.
await mkdirAsync(server.config().get('path.data'), { recursive: true });
} catch (err) {
server.log(['error', 'init'], err);
// Stop the server startup with a fatal error
throw err;
}
},

we need to move this to core

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Legacy Removal Issues related to removing legacy Kibana labels Jul 23, 2020
@pgayvallet
Copy link
Contributor Author

I'm unsure where this folder creation should be performed. I could create a data or a path service, but that feel like overkill to add a service just to perform a mkdir... Would putting that directly in src/core/server/server.ts be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant