Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Integration names should be globally unique #72948

Closed
caitlinbetz opened this issue Jul 22, 2020 · 8 comments · Fixed by #115212
Closed

[Fleet] Integration names should be globally unique #72948

caitlinbetz opened this issue Jul 22, 2020 · 8 comments · Fixed by #115212
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@caitlinbetz
Copy link

caitlinbetz commented Jul 22, 2020

Describe the feature:
Related to: #68019

Currently, an integration name is only required to be unique within an agent configuration. As a result, this can look a little confusing on the endpoint/policy side, as the integration name is tied to the policy name. We end up with a scenario where there can be multiple policies with the same name, where it's not clear what agent configurations they are tied to.

Example:
Onboarding:
image

Policy:
image

For 7.9 we are working on adding in a column in our Policy view to list the associated agent configurations so we are better able to distinguish any "duplicate" names. (However - it looks like you're still able to create multiple agent configurations with the same name, see the issue #68275). Longer term, it may ultimately be a better solution to have integration names be unique globally (rather than just within an agent configuration), especially as we are eventually planning to have these be re-usable (@ruflin mentions this briefly here)

@caitlinbetz caitlinbetz added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor

ph commented Oct 19, 2020

We have just added this #79903 which make Agent policy name unique across fleet.

@caitlinbetz With the above solution do we really need to make the integrations name unique? @ruflin you have mentioned previously that if we don't make it unique it could be a problem #68019 (comment).

For me this look like two differents names, one is a reusable name/searchable.

@ruflin
Copy link
Contributor

ruflin commented Oct 21, 2020

It still think we should also make integration policy names unique. It is not a strict requirement, but imagine you will have in a single Agent policy two integration policies called foo?

@jen-huang
Copy link
Contributor

@ruflin @ph We currently have implemented that agent policy names must be unique across Fleet and integration policy names must be unique per agent policy. Is this sufficient?

image

@ruflin
Copy link
Contributor

ruflin commented Oct 22, 2020

My thinking is that long term no, because of the policy templates we might build (see comment above).

Side note: In your screenshot the error message mentions packages, we should probably adjust this.

@ph
Copy link
Contributor

ph commented Oct 27, 2020

@ruflin Just trying to understand the why, for you, the "policy template" and the integration policy is at the same level this why you believe the name must be the same?

@ruflin
Copy link
Contributor

ruflin commented Oct 29, 2020

Let me give you an examples. Lets assume the following. User creates two polices:

  • Agent policy A
  • Agent policy B

In the Agent policy A, an integration policy with the name C is added. In addition, the user creates an reusable integration policy C and adds it to Agent policy B. All good so far. But now the user also assigns this policy to A. So A has now 2 integration policies with the name C.

All the above assumes we will have reusable integration policies.

@ph
Copy link
Contributor

ph commented Oct 29, 2020

I understand now, I would have taken a different approach similar to what "photoshop" or sketch does. Where the template name and integration policy name are different.
Template:

{
template_name: "EDF",
data: .......
}

Agent Policy integrations:

[
{
 Integration policy name: "Abc"
 linked: {
  type: "template"
  document_id:  "{UUID}"
 }
 }
]

@ph ph removed the v7.11.0 label Feb 15, 2021
@jen-huang jen-huang changed the title [Ingest Manager] Integration names should be globally unique [Fleet] Integration names should be globally unique Apr 27, 2021
@jen-huang jen-huang added the bug Fixes for quality problems that affect the customer experience label Oct 11, 2021
@criamico criamico self-assigned this Oct 13, 2021
@criamico criamico linked a pull request Oct 15, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants