Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Switch from HashRouter to platform-provided BrowserRouter #72013

Closed
9 tasks done
walterra opened this issue Jul 16, 2020 · 5 comments
Closed
9 tasks done

[ML] Switch from HashRouter to platform-provided BrowserRouter #72013

walterra opened this issue Jul 16, 2020 · 5 comments
Assignees
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features Meta :ml refactoring technical debt Improvement of the software architecture and operational architecture v7.10.0

Comments

@walterra
Copy link
Contributor

walterra commented Jul 16, 2020

Currently the ML plugin uses HashRouter for routing. We should switch over to the platform-provided BrowserRouter in order to be consistent with other apps and be able to handle query params better.

Docs: https://www.elastic.co/guide/en/kibana/current/breaking-changes-7.7.html#_add_scopedhistory_to_appmountparams

Todos

@walterra walterra added :ml Feature:Anomaly Detection ML anomaly detection refactoring technical debt Improvement of the software architecture and operational architecture v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Jul 16, 2020
@walterra walterra self-assigned this Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov
Copy link
Contributor

Aug-06-2020 14-21-08

Browser's history seems broken now. No matter which URL you navigate within ML app - the history gets replaced so the browser back button doesn't work as expected.

@qn895
Copy link
Member

qn895 commented Aug 12, 2020

Found an issue where clicking the breadcrumb works correctly but opening a new tab using the breadcrumb won’t yield the correct link.
E.g. Anomaly Detection will give http://localhost:5601/jobs instead of http://localhost:5601/app/ml/jobs

breadcrumb_linking

@qn895
Copy link
Member

qn895 commented Aug 20, 2020

Saw this issue where it was working correctly in 7.9 but not any more on main.

Fix the call out link to the index management page not going to the right path. Currently it will go to app/ml/data_frame_analytics/management/kibana/indexPatterns instead of app/management/kibana/indexPatterns
image

Just adding this note in just case so we can do check on other EuiLink components where href is used for linking to other apps in Kibana.

@peteharverson
Copy link
Contributor

Closing as all items have now been addressed for 7.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features Meta :ml refactoring technical debt Improvement of the software architecture and operational architecture v7.10.0
Projects
None yet
Development

No branches or pull requests

5 participants