-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'toExpression' function is removed in a plugin by Kibana core #71384
Comments
Pinging @elastic/kibana-app-arch (Team:AppArch) |
thanks @fbaligand i'll take a look |
Thanks @ppisljar This bug is blocking for my plugin. Despite a desperate workaround, the workaround is not called in several use cases :( |
sorry, this slipped my mind. This should be fixed by now, please reopen if you still encounter it. |
Yes, it is fixed since Kibana 7.10. I recently understood that issue was because « toExpression » function was not copied in basic_vis_type. |
Kibana version: 7.8.0
Describe the bug:
I develop a community visualization plugin: github.com/fbaligand/kibana-enhanced-table.
I noticed that 'toExpression' function declared in my visualization type is removed somewhere by Kibana core.
Unfortunately I can't figure out where exactly in Kibana core code.
The result is that 'build_pipeline.ts' don't find 'toExpression' function in vis type, and so, don't call it:
https://github.com/elastic/kibana/blob/7.8/src/plugins/visualizations/public/legacy/build_pipeline.ts#L528
I precise that this bug exist only since Kibana 7.8.0.
It works fine with earlier Kibana versions.
Steps to reproduce:
Expected behavior:
'toExpression' function in vis type not removed by Kibana core
Any additional context:
Here's my 'toExpression' function declaration:
https://github.com/fbaligand/kibana-enhanced-table/blob/master/public/enhanced-table-vis.js#L136
The text was updated successfully, but these errors were encountered: