Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ScopedHistoryMock compatible with ScopedHistory #71166

Closed
pgayvallet opened this issue Jul 8, 2020 · 1 comment · Fixed by #71404
Closed

Make ScopedHistoryMock compatible with ScopedHistory #71166

pgayvallet opened this issue Jul 8, 2020 · 1 comment · Fixed by #71404
Assignees
@pgayvallet
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 8, 2020 •
edited
Loading

Our ScopedHistoryMock mock type does not properly implements ScopedHistory, forcing consumers to use workarounds to properly use it in tests.

We should fix that, so that const scopedHistory: ScopedHistory = scopedHistoryMock.create() becomes a valid statement.

See #70768 for example
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

This was referenced Jul 8, 2020
Merged
Merged
@pgayvallet pgayvallet self-assigned this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ScopedHistory mock and adapt usages pgayvallet/kibana
2 participants
@pgayvallet @elasticmachine